leahi-fwcommon

TestSupport.h

Clone Tools

Stats

Commits this week: 10
Total Committers: 9
Last Commit: 04 Feb
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

3:36 pm

Vinayakam Mani

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

2:34 pm

Vendor - TEL - Varshini Nagabooshanam

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

2:10 pm

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:45 am

Sean Nash

Remove blank line.

Remove blank line.

11:43 am

Sean Nash

Looks like this reverted back.

Looks like this reverted back.

11:34 am

Raghu Kallala

11:30 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:24 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

10:02 am

Raghu Kallala

LDT-3343 removed duplicate test config for rinse pump

Options
    • -2
    • +1
    /TestSupport.h
6:24 am

Raghu Kallala

Updated

Updated

6:23 am

Raghu Kallala

Fixed

Fixed

Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

3:00 pm

Sean Nash

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

2:59 pm

Sean Nash

Remove blank line.

Remove blank line.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

8:45 am

Raghu Kallala

LDT-3343 added test config to run DD alone

Options
    • -0
    • +1
    /TestSupport.h
Monday 02 Feb
3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:17 pm

Vendor - TEL - Sameer Poyil

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle