ModeService.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Balancing chamber switching control

Balancing chamber switching control

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

remove the space before false.

remove the space before false.

Remove blank line

Remove blank line

Remove blank line.

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Remove blank line and comment saying we're not doing anything (because now we're doing something).

Remove blank line and comment saying we're not doing anything (because now we're doing something).

isBalChamberSwitchingOffRequested is an output.

isBalChamberSwitchingOffRequested is an output.

Should we set the other switch to FALSE, just in case?

Should we set the other switch to FALSE, just in case?

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases. And I don't think we should be setting result to TRUE here necessarily. If we...

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.