dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 12
Total Committers: 5
Last Commit: 10:53
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
40 mins ago

Vendor - TEL - Sameer Poyil

LDT-3980- adjusting bicarb kp gain

Options
    • -1
    • +1
    ./DryBiCart.c
Tuesday 21 Apr
1:02 pm

Vendor - TEL - Sameer Poyil

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine ...

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

9:02 am

Sean Nash

This code looks very similar to bicarb code above. Do we really need separate handling?

This code looks very similar to bicarb code above. Do we really need separate handling?

5:48 am

Vendor - TEL - Sameer Poyil

LDT-3980 firmware development for dry bicart updates

Options
    • -8
    • +8
    ./DryBiCart.c
5:39 am

Vendor - TEL - Sameer Poyil

LDT-3980 firmware development for dry bicart

Options
    • -32
    • +74
    ./DryBiCart.c
  2. … 1 more file in changeset.
Monday 20 Apr
5:31 pm

Sean Nash

5:31 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:08 pm

Sean Nash

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

11:30 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1:
11:22 am

Vendor - TEL - Sameer Poyil

LDT-3980-Dry bicarb firmware implementation for initial fill request

Options
    • -10
    • +25
    ./DryBiCart.c
8:17 am

Vendor - TEL - Sameer Poyil

Thursday 16 Apr
11:17 pm

Sean Nash and Vinayakam Mani

11:13 pm

Sean Nash

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:23 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:19 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./DryBiCart.c
  2. … 8 more files in changeset.
4:13 pm

Vendor - TEL - Sameer Poyil

LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

Options
    • -1
    • +1
    ./DryBiCart.c
  2. … 5 more files in changeset.
2:55 pm

Vendor - TEL - Sameer Poyil

LDT-2004 addressed review comments

Options
    • -5
    • +0
    ./DryBiCart.c
2:42 pm

Vendor - TEL - Sameer Poyil

LDT-2004 adressed review comments

Options
    • -16
    • +9
    ./DryBiCart.c
2:28 pm

Vendor - TEL - Sameer Poyil

Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

Wednesday 15 Apr
10:08 pm

Vendor - TEL - Sameer Poyil

LDT-2004 Adressed review comments

Options
    • -107
    • +55
    ./DryBiCart.c
  2. … 1 more file in changeset.
9:34 pm

Vendor - TEL - Sameer Poyil

0.0F is made by Sean.

0.0F is made by Sean.

Tuesday 14 Apr
7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

7:11 pm

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

7:02 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

6:58 pm

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

6:51 pm

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

6:21 pm

Vinayakam Mani

This is being repeated.

This is being repeated.

6:20 pm

Vinayakam Mani

Please add comment. if it is not being used, delete it.

Please add comment. if it is not being used, delete it.