leahi-dialin / leahi_dialin / dd

modules

Clone Tools

Stats

Commits this week: 5
Total Committers: 10
Last Commit: 30 Apr
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
4:54 pm

Michael Garthwaite

LDT-4000: updated message IDs. Updated test config for beta 1.9 and 2.0. implemented substitution pump module

Options
    • -0
    • +112
    ./substitution_pump.py
  2. … 3 more files in changeset.
4:33 pm

Vendor - TEL - Sameer Poyil

4:28 pm

Michael Garthwaite and Raghu Kallala

3:34 pm

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
3:28 pm

Vendor - TEL - Sameer Poyil

LDT-3984-unit-test-failure-fix

Options
    • -1
    • +1
    ./levels.py
2:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
2:23 pm

Vendor - TEL - Sameer Poyil

2:22 pm

Michael Garthwaite

LDT-4000: fixed unit testing

Options
    • -1
    • +1
    ./levels.py
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

8:44 pm

Vendor - TEL - Sameer Poyil

LDT-3984 fix for conductivie level sensors d46, d63,d98

Options
    • -3
    • +2
    ./levels.py
  2. … 3 more files in changeset.
Friday 24 Apr
10:45 pm

Vendor - TEL - Sameer Poyil

LDT-3984 conductive level sensor dialin implementation

Options
    • -0
    • +27
    ./levels.py
  2. … 2 more files in changeset.
10:40 am

Zoltan Miskolci

Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
8:00 am

Vendor - TEL - Sameer Poyil

LDT-3984 aligning D46 with DD firmware

Options
    • -3
    • +3
    ./levels.py
  2. … 1 more file in changeset.
Wednesday 22 Apr
11:48 am

Raghu Kallala and Michael Garthwaite

Friday 17 Apr
2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

12:05 pm

Dara Navaei

LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
11:01 am

Zoltan Miskolci

Renamed Heater Attribute from duty cycle count to feed forward

Options
    • -41
    • +32
    ./heaters.py
Tuesday 14 Apr
9:44 am

Vendor - TEL - Arpita Srivastava

Wednesday 08 Apr
11:26 am

Zoltan Miskolci

10:01 am

Michael Garthwaite and Raghu Kallala

9:48 am

Raghu Kallala

Typo, response

Typo, response

9:48 am

Raghu Kallala

Typo, response

Typo, response