dd-firmware / firmware / App / Controllers

Heaters.c

Clone Tools

Stats

Commits this week: 4
Total Committers: 7
Last Commit: 25 Jun
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Jun
4:15 pm

Vendor - TEL - Arpita Srivastava

Add previousHeaterState to input and output

Add previousHeaterState to input and output

4:13 pm

Vendor - TEL - Arpita Srivastava

add prevDryBicartState to input and output.

add prevDryBicartState to input and output.

4:11 pm

Vendor - TEL - Arpita Srivastava

Add prevBalChamberState to input and output

Add prevBalChamberState to input and output

4:09 pm

Vendor - TEL - Arpita Srivastava

Add isBalChamberSwitchingActive to input

Add isBalChamberSwitchingActive to input

2:40 pm

Vinayakam Mani

Align it with declration.

Align it with declration.

2:39 pm

Vinayakam Mani

Add comments.

Add comments.

1:46 pm

Vendor - TEL - Jashwant Gantyada

1:17 pm

Sean Nash

10:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Wednesday 24 Jun
6:36 am

Raghu Kallala

Thursday 18 Jun
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

Thursday 11 Jun
2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Heaters.c
  2. … 12 more files in changeset.
2:24 pm

Michael Garthwaite

1:27 pm

Vinayakam Mani and Sean Nash

10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:00 am

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

9:58 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

9:57 am

Michael Garthwaite

this is speed in rpm

this is speed in rpm

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks