Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
Merge conflicts with staging resolved and comments

  1. … 3 more files in changeset.
Add previousHeaterState to input and output

Add previousHeaterState to input and output

add prevDryBicartState to input and output.

add prevDryBicartState to input and output.

Add prevBalChamberState to input and output

Add prevBalChamberState to input and output

Add isBalChamberSwitchingActive to input

Add isBalChamberSwitchingActive to input

Align it with declration.

Align it with declration.

Add comments.

Add comments.

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Code changes for CR

  1. … 3 more files in changeset.
Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

Space after 0

Space after 0

prevDryBicartState

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

prevBalChamberState?

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

LDT-4539: Add state-change event logging to DD modules (BalancingChamber, DryBiCart, Heaters, Ultrafiltration)

  1. … 4 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 12 more files in changeset.
fixed thanks

fixed thanks

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

fixed thanks

fixed thanks