dd-firmware

Clone Tools

Stats

Commits this week: 65
Total Committers: 15
Last Commit: 16:36
Commits this week: 65

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Feb
2:59 pm

Vinayakam Mani

LDT-1473 code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
2:57 pm

Michael Garthwaite

LDT-2990: removed duplicate structure. code review comments.

Options
    • -14
    • +0
    /firmware/App/DDCommon.h
    • -10
    • +1
    /firmware/App/Services/Messaging.c
2:49 pm

Vinayakam Mani

Updated.

Updated.

2:49 pm

Vinayakam Mani

LDT-1473 resolving code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:30 pm

Sean Nash

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

2:29 pm

Vendor - TEL - Arpita Srivastava

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

2:24 pm

Sean Nash

In °C?

In °C?

2:23 pm

Vinayakam Mani

LDT-1473 resolving merge conflicts

Options
    • -172
    • +204
    /firmware/App/Controllers/BalancingChamber.c
    • -4
    • +4
    /firmware/App/Controllers/ConcentratePumps.c
    • -12
    • +50
    /firmware/App/Modes/ModeGenDialysate.c
    • -5
    • +5
    /firmware/App/Monitors/Temperature.c
2:23 pm

Sean Nash

Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.

2:23 pm

Vendor - TEL - Arpita Srivastava

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

2:02 pm

Vinayakam Mani

Done

Done

2:02 pm

Vinayakam Mani

Done.

Done.

2:02 pm

Vinayakam Mani

LDT-1473 code review comments

Options
    • -1
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +0
    /firmware/App/Controllers/Heaters.c
1:49 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
1:34 pm

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

1:33 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:33 pm

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

1:31 pm

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

1:28 pm

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

1:26 pm

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().

1:25 pm

Sean Nash

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

1:23 pm

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
    • -2
    • +2
    /firmware/App/Services/Messaging.c
1:23 pm

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Options
12:47 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
12:41 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/Valves.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivityTeensy.c
    • -1
    • +1
    /firmware/App/Drivers/ConductivityTeensy.h
    • -2
    • +2
    /firmware/App/Services/Messaging.c
12:01 pm

Vendor - TEL - Arpita Srivastava

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function. Should we add bloodLeakEmbModeCmdQ to the list?

I do not see bloodLeakDataPublicationTimerCounter being initialized in the function.
Should we add bloodLeakEmbModeCmdQ to the list?

11:59 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
11:58 am

Michael Garthwaite

Merge branch 'LDT-2990-iofp-fw-and-fpga-version' into develop

Options
    • -0
    • +14
    /firmware/App/DDCommon.h
    • -0
    • +12
    /firmware/App/Services/Messaging.c