Activity dd-firmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 21

Total Committers:	15
Last Commit:	18 Jun
Commits this week:	21

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 15 Jun

11:18 am

Vendor - TEL - Sameer Poyil

More
5531ef9
changed 5 files
LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more LEAHI-DD-FIRMWARE-LDT-4409-2

LDT-4409 enable dry bicart default

- -5
- +5
./BalancingChamber.c
- History
- Source
- Diff
./BalancingChamber.c
- -17
- +12
./MixingControl.h
- History
- Source
- Diff
./MixingControl.h
… 3 more files in changeset.

8:17 am

Vendor - TEL - Sameer Poyil

More
cd11615
changed 6 files
LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more LEAHI-DD-FIRMWARE-LDT-4409-2

LDT-4409 dry bicart implementation plus refactoring closed loop control

- -0
- +1
./BalancingChamber.c
- History
- Source
- Diff
./BalancingChamber.c
- -14
- +25
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
- -0
- +3
./DryBiCart.h
- History
- Source
- Diff
./DryBiCart.h
- -0
- +1136
./MixingControl.c
- History
- Source
./MixingControl.c
- -0
- +96
./MixingControl.h
- History
- Source
./MixingControl.h
… 1 more file in changeset.

Friday 12 Jun

2:19 pm

Michael Garthwaite

More
35ccc44
changed 5 files
develop

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

- -7
- +7
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +2
./RinsePump.c
- History
- Source
- Diff
./RinsePump.c
… 3 more files in changeset.

2:18 pm

Michael Garthwaite

More
b3e9afd
changed 1 file
LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more LEAHI-DD-FIRMWARE-LDT-4485-1

LDT-4485: fixed pumpid call

- -1
- +1
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c

2:13 pm

Michael Garthwaite

More
5162e2a
changed 1 file
LDT-4410-dialysate-composition-mixing-2, LDT-4485-dd-conductivity-sensors-d17 and 3 more LEAHI-DD-FIRMWARE-LDT-4485-1

LDT-4485: updates to sub pump rpm measure alarm to not monitor during off state.

- -1
- +5
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c

9:14 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4011-1
commented on review

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4011-1
commented on review

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4011-1
commented on review

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4011-1
commented on review

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

8:25 am

Vendor - TEL - Sameer Poyil

More
fc26356
changed 2 files
LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 3 more LEAHI-DD-FIRMWARE-LDT-4409-2

LDT-4409 addressed review comments

- -859
- +103
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
- -40
- +0
./DryBiCart.h
- History
- Source
- Diff
./DryBiCart.h

7:12 am

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

6:49 am

Vendor - TEL - Sameer Poyil

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

6:45 am

Vendor - TEL - Sameer Poyil

will address it in new file created for mixing

will address it in new file created for mixing

Thursday 11 Jun

3:44 pm

Vendor - TEL - Arpita Srivastava

More
1fa3818
changed 25 files
LDT-3735-non-volatile-memory LEAHI-DD-FIRMWARE-LDT-3735-1

LDT-3735: Moved the file NVDriver, NVJobQ and NVMgmt to FwCommon

- -1
- +1
./BoostPump.c
- History
- Source
- Diff
./BoostPump.c
- -1
- +1
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -1
- +1
./DialysatePumps.c
- History
- Source
- Diff
./DialysatePumps.c
- -1
- +1
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -1
- +1
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 20 more files in changeset.

2:27 pm

Dara Navaei

More
9eae2f6
changed 13 files
LDT-4409-dialysate-composition-beta-2.1-WCID-implementation, LDT-4410-dialysate-composition-mixing-2 and 6 more LEAHI-DD-FIRMWARE-LDT-4485-1 LEAHI-DD-FIRMWARE-LDT-4409-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Heaters.c
- History
- Source
- Diff
./Heaters.c
- -2
- +2
./RinsePump.c
- History
- Source
- Diff
./RinsePump.c
- -5
- +5
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c
- -4
- +4
./SubstitutionPump.h
- History
- Source
- Diff
./SubstitutionPump.h
… 9 more files in changeset.

2:24 pm

Michael Garthwaite

1:27 pm

Vinayakam Mani and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-4001-1
finished reviewing

12:28 pm

Michael Garthwaite

More
656b372
changed 1 file
LDT-4001-hdf-fw-implementation-2-4, LDT-4409-dialysate-composition-beta-2.1-WCID-implementation and 7 more LEAHI-DD-FIRMWARE-LDT-4001-1

LDT-4001: code review comments

- -13
- +5
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c

10:10 am

Michael Garthwaite

More
4a1f051
changed 2 files
LDT-4001-hdf-fw-implementation-2-4, LDT-4409-dialysate-composition-beta-2.1-WCID-implementation and 7 more LEAHI-DD-FIRMWARE-LDT-4001-1

LDT-4001: code review comments

- -4
- +6
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c
… 1 more file in changeset.

10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:00 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-4001-1
commented on review

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

9:58 am

Michael Garthwaite

fixed thanks

fixed thanks

9:58 am

Michael Garthwaite

More
83d4e43
changed 1 file
LDT-4001-hdf-fw-implementation-2-4, LDT-4409-dialysate-composition-beta-2.1-WCID-implementation and 7 more LEAHI-DD-FIRMWARE-LDT-4001-1

LDT-4001: code review updates

- -3
- +3
./SubstitutionPump.c
- History
- Source
- Diff
./SubstitutionPump.c

9:57 am

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

9:57 am

Michael Garthwaite

this is speed in rpm

this is speed in rpm

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-20 09:25 -0700