Controllers

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4409 enable dry bicart default

  1. … 3 more files in changeset.
LDT-4409 dry bicart implementation plus refactoring closed loop control

    • -0
    • +1136
    ./MixingControl.c
  1. … 1 more file in changeset.
Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

  1. … 3 more files in changeset.
LDT-4485: fixed pumpid call

LDT-4485: updates to sub pump rpm measure alarm to not monitor during off state.

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

Why only these states are valid?

Why only these states are valid?

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

LDT-4409 addressed review comments

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

will address it in new file created for mixing

will address it in new file created for mixing

LDT-3735: Moved the file NVDriver, NVJobQ and NVMgmt to FwCommon

  1. … 20 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
LDT-4001: code review comments

LDT-4001: code review comments

  1. … 1 more file in changeset.
fixed thanks

fixed thanks

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

fixed thanks

fixed thanks

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

fixed thanks

fixed thanks

LDT-4001: code review updates

this is a set speed in rpm

this is a set speed in rpm

this is speed in rpm

this is speed in rpm

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks