dd-firmware / firmware / App / Modes

ModeGenDialysate.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 23 Apr
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Apr
10:57 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeGenDialysate.h
  2. … 12 more files in changeset.
10:42 am

Raghu Kallala

LDT-3749 resolved merge conflict with staging

Options
    • -3
    • +3
    ./ModeGenDialysate.h
  2. … 6 more files in changeset.
10:41 am

Raghu Kallala

9:55 am

Vinayakam Mani

Tuesday 21 Apr
2:17 pm

Sean Nash

8:34 am

Raghu Kallala

Updated

Updated

Friday 17 Apr
9:54 am

Vinayakam Mani

Tuesday 14 Apr
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeGenDialysate.h
  2. … 12 more files in changeset.
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

4:39 pm

Vinayakam Mani

LDT-3352 resolving merge issues

Options
    • -2
    • +1
    ./ModeGenDialysate.h
  2. … 10 more files in changeset.
Monday 13 Apr
2:58 pm

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

12:00 pm

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:56 am

Vinayakam Mani

Done.

Done.

11:56 am

Vinayakam Mani

Done.

Done.

Friday 10 Apr
3:01 pm

Vendor - TEL - Jashwant Gantyada

1:47 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ModeGenDialysate.h
  2. … 2 more files in changeset.
1:42 pm

Vinayakam Mani and Sean Nash

11:53 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 resolved merge conflicts

Options
    • -1
    • +0
    ./ModeGenDialysate.h
  2. … 2 more files in changeset.
11:52 am

Vinayakam Mani

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

11:14 am

Vinayakam Mani

Delete the macro if not being used.

Delete the macro if not being used.

8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).