Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2030 addressed code review comments

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT3344 updated rinsepump to work for beta1 and beta2

done.

done.

done.

done.

done.

done.

LDT-3344- f/w changes for integrating beta 2 h/w

LDT-3352 resolving merge conflicts

Revert "Merge branch 'staging' into LDT-2004-v2-conductivity-sensors"

This reverts commit 1c4e2ce92ecb2e4b4301aba7bd2b869f1116d0f6, reversing

changes made to 7ec185a54b1c51b69dd0937b45d24a485d2aeef5.

    • -28
    • +36
    ./Controllers/BalancingChamber.c
    • -22
    • +31
    ./Controllers/ConcentratePumps.c
Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

LDT-3344 removed extra spaces

LDT-3103 special build enabling new D48 pump changes

    • -26
    • +34
    ./Controllers/BalancingChamber.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' into LDT-2990-iofp-fw-and-fpga-version

Done.

Done.

LDT-1473 code review comments

LDT-2990: removed duplicate structure. code review comments.

Updated.

Updated.

LDT-1473 resolving code review comments

copy paste error comment

copy paste error comment

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

In °C?

In °C?

LDT-1473 resolving merge conflicts

    • -172
    • +204
    ./Controllers/BalancingChamber.c
Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

Done

Done