dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 45
Total Committers: 16
Last Commit: 16:40
Commits this week: 45

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Apr
4:09 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Deleted NVM records for scheduled runs, heater info and sw config

Options
    • -7
    • +0
    ./Drivers/NVDriver.h
    • -54
    • +99
    ./Services/NVMsgQ.c
    • -7
    • +11
    ./Services/NVMsgQ.h
    • -178
    • +10
    ./Services/NVRecordsDD.c
    • -96
    • +2
    ./Services/NVRecordsDD.h
3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

1:10 pm

Raghu Kallala

COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

11:31 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
11:30 am

Vinayakam Mani

LDT-3352 resolving merge conflicts

Options
    • -18
    • +18
    ./Controllers/BalancingChamber.c
    • -13
    • +11
    ./Controllers/Heaters.c
    • -3
    • +3
    ./Controllers/Ultrafiltration.c
    • -2
    • +2
    ./DDCommon.h
    • -92
    • +130
    ./Drivers/ConductivitySensors.c
    • -6
    • +7
    ./Modes/ModeGenDialysate.c
    • -2
    • +14
    ./Monitors/Conductivity.c
    • -5
    • +7
    ./Services/AlarmMgmtSWFaults.h
    • -3
    • +3
    ./Services/FpgaDD.c
    • -4
    • +5
    ./Services/Messaging.c
11:05 am

Michael Garthwaite

Do we know which channel this event will be sent on?

Do we know which channel this event will be sent on?

10:06 am

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow-CLEAN

Options
    • -2
    • +3
    ./Services/Messaging.c
10:05 am

Michael Garthwaite

Merge branch 'staging' into LDT-3777-sprint-25-fixes

Options
    • -2
    • +2
    ./Drivers/ConductivitySensors.c
    • -2
    • +2
    ./Drivers/ConductivitySensors.h
    • -1
    • +1
    ./Monitors/Conductivity.c
9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -0
    • +1
    ./Controllers/ROPump.c
    • -3
    • +4
    ./Controllers/Valves.c
    • -1
    • +1
    ./Controllers/Valves.h
    • -1
    • +1
    ./Services/FpgaDD.c
7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

LDT-3777: code review comments

Options
    • -0
    • +3
    ./Drivers/ConductivitySensors.c
Tuesday 14 Apr
9:23 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Controllers/Ultrafiltration.c
    • -1
    • +1
    ./DDCommon.h
    • -2
    • +2
    ./Drivers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.h
    • -2
    • +2
    ./Monitors/Temperature.c
    • -1
    • +1
    ./Monitors/Temperature.h
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/Messaging.c
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

7:11 pm

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

7:02 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

6:58 pm

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

6:51 pm

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

6:21 pm

Vinayakam Mani

This is being repeated.

This is being repeated.

6:20 pm

Vinayakam Mani

Please add comment. if it is not being used, delete it.

Please add comment. if it is not being used, delete it.