firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Remove the empty space.

Remove the empty space.

Can we remove this #if check? we can keep the comment.

Can we remove this #if check? we can keep the comment.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

can we get each group of level check in to a function and call those functions for each case?

can we get each group of level check in to a function and call those functions for each case?

Minor: Please add space in [cmd].

Minor: Please add space in [cmd].

Should it be bloodLeakEmbModeCmd?

Should it be bloodLeakEmbModeCmd?

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-3344 merged into develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-3344 added get functions for newly implemented sensors

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

changed.

changed.

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

Remove blank line.

Remove blank line.

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Why not "TRUE == "?

Why not "TRUE == "?

Why not "TRUE == "?

Why not "TRUE == "?

Remove blank line.

Remove blank line.

Remove extra blank line.

Remove extra blank line.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Why did this file get deleted?

Why did this file get deleted?

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

fixed.

fixed.