dd-firmware

firmware

Clone Tools

Stats

Commits this week: 41
Total Committers: 16
Last Commit: 07:44
Commits this week: 41

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Apr
10:08 pm

Vendor - TEL - Sameer Poyil

LDT-2004 Adressed review comments

Options
    • -2
    • +2
    ./App/Controllers/ConcentratePumps.h
    • -107
    • +55
    ./App/Controllers/DryBiCart.c
9:34 pm

Vendor - TEL - Sameer Poyil

0.0F is made by Sean.

0.0F is made by Sean.

5:33 pm

Sean Nash

5:33 pm

Sean Nash

5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

4:09 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Deleted NVM records for scheduled runs, heater info and sw config

Options
    • -7
    • +0
    ./App/Drivers/NVDriver.h
    • -54
    • +99
    ./App/Services/NVMsgQ.c
    • -7
    • +11
    ./App/Services/NVMsgQ.h
    • -178
    • +10
    ./App/Services/NVRecordsDD.c
    • -96
    • +2
    ./App/Services/NVRecordsDD.h
3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

1:10 pm

Raghu Kallala

COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

11:31 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
11:30 am

Vinayakam Mani

LDT-3352 resolving merge conflicts

Options
    • -18
    • +18
    ./App/Controllers/BalancingChamber.c
    • -13
    • +11
    ./App/Controllers/Heaters.c
    • -3
    • +3
    ./App/Controllers/Ultrafiltration.c
    • -2
    • +2
    ./App/DDCommon.h
    • -92
    • +130
    ./App/Drivers/ConductivitySensors.c
    • -6
    • +7
    ./App/Modes/ModeGenDialysate.c
    • -2
    • +14
    ./App/Monitors/Conductivity.c
    • -5
    • +7
    ./App/Services/AlarmMgmtSWFaults.h
    • -3
    • +3
    ./App/Services/FpgaDD.c
    • -4
    • +5
    ./App/Services/Messaging.c
11:05 am

Michael Garthwaite

Do we know which channel this event will be sent on?

Do we know which channel this event will be sent on?

10:06 am

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow-CLEAN

Options
    • -2
    • +3
    ./App/Services/Messaging.c
10:05 am

Michael Garthwaite

Merge branch 'staging' into LDT-3777-sprint-25-fixes

Options
    • -2
    • +2
    ./App/Drivers/ConductivitySensors.c
    • -2
    • +2
    ./App/Drivers/ConductivitySensors.h
    • -1
    • +1
    ./App/Monitors/Conductivity.c
9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -0
    • +1
    ./App/Controllers/ROPump.c
    • -3
    • +4
    ./App/Controllers/Valves.c
    • -1
    • +1
    ./App/Controllers/Valves.h
    • -1
    • +1
    ./App/Services/FpgaDD.c
7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

LDT-3777: code review comments

Options
    • -0
    • +3
    ./App/Drivers/ConductivitySensors.c
Tuesday 14 Apr
9:23 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/BalancingChamber.c
    • -2
    • +2
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Controllers/Heaters.h
    • -2
    • +2
    ./App/Controllers/RinsePump.c
    • -1
    • +1
    ./App/Controllers/Ultrafiltration.c
    • -1
    • +1
    ./App/DDCommon.h
    • -2
    • +2
    ./App/Drivers/TemperatureSensors.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.c
    • -2
    • +2
    ./App/Modes/ModeGenDialysate.h
    • -2
    • +2
    ./App/Monitors/Temperature.c
    • -1
    • +1
    ./App/Monitors/Temperature.h
    • -2
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./App/Services/Messaging.c
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.