leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2998

LDT-1415 added messages for the UI team

Done

Done

Done

Done

Done

Done

Update inputs/outputs throughout this unit.

Update inputs/outputs throughout this unit.

Update outputs to include the start time.

Update outputs to include the start time.

Update inputs/outputs. I think more have been added.

Update inputs/outputs. I think more have been added.

Use OVERRIDE_RESET instead of 0.

Use OVERRIDE_RESET instead of 0.

Remove extra blank line.

Remove extra blank line.

We should use the #defines for .override assignments (i.e. OVERRIDE_RESET or OVERRIDE_KEY).

We should use the #defines for .override assignments (i.e. OVERRIDE_RESET or OVERRIDE_KEY).

Function prototypes do not require comments to right, but for consistency we should add one here since all the other prototypes have comments.

Function prototypes do not require comments to right, but for consistency we should add one here since all the other prototypes have comments.

state is not an input. It is a local (internal to function) variable.

state is not an input. It is a local (internal to function) variable.

Remove extra blank line.

Remove extra blank line.

Remove blank line.

Remove blank line.

Add comment to right.

Add comment to right.

remove empty line.

remove empty line.

Move the actuators into drain start state.

Move the actuators into drain start state.

remove empty space/s

remove empty space/s

Remove this macro.

Remove this macro.

Please rename as DRY_BICART_FILL_VENT_TIME_MS

Please rename as DRY_BICART_FILL_VENT_TIME_MS

Remove if it is not being used.

Remove if it is not being used.

add space at end of close parenthesis.

add space at end of close parenthesis.

bicarbChamberPeriodicFillCounter

bicarbChamberPeriodicFillCounter

BICARB_CHAMBER_PERIODIC_FILL_TIME

BICARB_CHAMBER_PERIODIC_FILL_TIME

Added

Added

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

This is a testable value.

This is a testable value.

Should we remove the condition instead of commenting it out?

Should we remove the condition instead of commenting it out?

An alarm is triggered in this function. Add to header.

An alarm is triggered in this function. Add to header.