Activity leahi-common/

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts? This wouldn't be an issue ...

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts?
This wouldn't be an issue if we combined the 3 state machines.

9:21 am

Dara Navaei

More
760499c
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-h4-rotor-count and 29 more LEAHI-DD-FIRMWARE-LDT-2004-3 LEAHI-TD-FIRMWARE-LDT-1415-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

9:18 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1415-1
commented on review

I think this should be commented out before we merge to staging.

9:17 am

Michael Garthwaite

More
ba082ec
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-h4-rotor-count and 29 more

Merge branch 'LDT-2004-dialysate-composition-dd' into staging

9:15 am

Michael Garthwaite

10:14 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-2004-3
commented on review

Complex conditional expressions can be avoided. Introduce temporary boolean variables instead. for example if ((elementNo < 0) || (elementNo > maxElement)|| elementNo == lastElement){ … } should b...

Complex conditional expressions can be avoided. Introduce
temporary boolean variables instead.

for example
if ((elementNo < 0) || (elementNo > maxElement)||
elementNo == lastElement)

Unknown macro: { … }

should be replaced by:
isFinished = (elementNo < 0) || (elementNo > maxElement);
isRepeatedEntry = elementNo == lastElement;
if ((isFinished == TRUE) || (isRepeatedEntry == TRUE))

4:32 pm

Vendor - TEL - Sameer Poyil

its rate , pump speed in ml/min

3:32 pm

Vendor - TEL - Varshini Nagabooshanam

More
LEAHI-TD-FIRMWARE-LDT-1415-1
started review

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD

3:04 pm

Vendor - TEL - Sameer Poyil

Fixed.

3:02 pm

Vendor - TEL - Sameer Poyil

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE Its fixed now

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE
Its fixed now

12:12 pm

Sean Nash

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

11:53 am

Vendor - TEL - Sameer Poyil

right now, only bicarbChamberFillRequested is cleared during the supply. dryBiCartFillRequested and dryBiCartDrainRequested has a Fill/Drain complete state and it remains in that state to check com...

right now, only bicarbChamberFillRequested is cleared during the supply. dryBiCartFillRequested and dryBiCartDrainRequested has a Fill/Drain complete state and it remains in that state to check completion state programmatically. an explicit clear request is required to start the next operation. Do I need to clear it ?

11:33 am