leahi-common

Clone Tools

Stats

Commits this week: 16
Total Committers: 19
Last Commit: 29 May
Commits this week: 16

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 25 Feb
12:49 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

12:48 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

12:32 pm

Vendor - TEL - Sameer Poyil

its a standard c library , for that no need to comment. using ceil() function

its a standard c library , for that no need to comment. using ceil() function

12:30 pm

Vendor - TEL - Sameer Poyil

This is a default framework for all modules, even though there is nothing right now, left it as it is.

This is a default framework for all modules, even though there is nothing right now, left it as it is.

11:49 am

Vendor - TEL - Jashwant Gantyada

I don't see it being used in this state. Do we need this?

I don't see it being used in this state. Do we need this?

9:33 am

Vendor - TEL - Jashwant Gantyada

I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

9:27 am

Vendor - TEL - Jashwant Gantyada

I think we have to define macros for magic number.

I think we have to define macros for magic number.

9:24 am

Sean Nash

Why NUM_OF_?

Why NUM_OF_?

9:23 am

Sean Nash

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it? And we should initialize in the init function - not here.

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it?
And we should initialize in the init function - not here.

9:23 am

Vendor - TEL - Jashwant Gantyada

I think we have to include a comment specifying what function is being used from this file.

I think we have to include a comment specifying what function is being used from this file.

9:22 am

Sean Nash

Is this really a timer counter? Looks like a flow rate.

Is this really a timer counter? Looks like a flow rate.

9:19 am

Sean Nash

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Added back

Added back

9:04 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Tuesday 24 Feb
2:47 pm

Sean Nash

11:55 am

Vendor - TEL - Jashwant Gantyada

10:35 am

Raghu Kallala , Vinayakam Mani and Sean Nash

10:01 am

Sean Nash

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly nec...

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly necessary.

9:59 am

Sean Nash

Add blank line before return.

Add blank line before return.

9:58 am

Sean Nash

0.0F

0.0F

9:58 am

Sean Nash

Use "F64" macro instead of double.

Use "F64" macro instead of double.

9:48 am

Vendor - TEL - Sameer Poyil

Yes , right now its void , so that's why i didn't change that . I will push new code

Yes , right now its void , so that's why i didn't change that . I will push new code

9:30 am

Sean Nash

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

9:24 am

Sean Nash

Inputs is none or FPGA.

Inputs is none or FPGA.

8:15 am

Vendor - TEL - Sameer Poyil

done

done

8:14 am

Vendor - TEL - Sameer Poyil

done , but I need to check it here

done , but I need to check it here

8:14 am

Vendor - TEL - Sameer Poyil

done

done

Monday 23 Feb
6:29 pm

Vendor - TEL - Sameer Poyil

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

6:27 pm

Vendor - TEL - Sameer Poyil

its a reverse logic - is it OK to make positive instead of not defined ?

its a reverse logic - is it OK to make positive instead of not defined ?