Activity leahi-common/

4 hrs ago

Vendor - TEL - Arpita Srivastava

More
4752dd6
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching LEAHI-DD-FIRMWARE-LDT-1195-2

LDT-1195: Added balancing chamber idle state

- -0
- +1
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
replied to Vendor - TEL - Jashwant Gantyada

its a standard c library , for that no need to comment. using ceil() function

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
replied to Vendor - TEL - Jashwant Gantyada

it is used for publish

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
replied to Vendor - TEL - Jashwant Gantyada

This is a default framework for all modules, even though there is nothing right now, left it as it is.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

I don't see it being used in this state. Do we need this?

10 hrs ago

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

10 hrs ago

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

I think we have to define macros for magic number.

10 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Why NUM_OF_?

10 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it? And we should initialize in the init function - not here.

Variable name suggests it is an action/cmd from UI. Comment suggests it is the number of actions. Which is it?
And we should initialize in the init function - not here.

10 hrs ago

Vendor - TEL - Jashwant Gantyada

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

I think we have to include a comment specifying what function is being used from this file.

10 hrs ago

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-3126-1
commented on review

Is this really a timer counter? Looks like a flow rate.

10 hrs ago

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-473-2
finished reviewing

10 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

10 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Added back

10 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Updated

7:56 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1903-8
resumed reviewing

2:47 pm

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-1903-8
added Raghu Kallala , Vendor - TEL - Arpita Srivastava and Vendor - TEL - Jashwant Gantyada

11:55 am

Vendor - TEL - Jashwant Gantyada

10:45 am

Raghu Kallala

More
6c58af8
changed 0 files
develop

LDT-3344 merge Beta2.0 changes to develop

10:38 am

Dara Navaei

More
c138b6c
changed 2 files
LDT-1195-dd-is-balancing-chamber-switching, staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/AlarmDefs.h
- History
- Source
- Diff
/AlarmDefs.h
- -2
- +2
/DDDefs.h
- History
- Source
- Diff
/DDDefs.h

10:35 am

Raghu Kallala

More
4e8ec9a
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, staging

LDT-3344 merge Beta2.0 changes to staging

10:35 am

Raghu Kallala , Vinayakam Mani and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3344-1
finished reviewing

10:01 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1903-8
commented on review

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly nec...

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly necessary.

9:59 am