Activity leahi-common/

12:44 pm

Raghu Kallala

More
1d366a7
changed 1 file
LDT-473-treatment-parameters-create-rx-latest LEAHI-TD-FIRMWARE-LDT-473-3

LDT-473 addressed review comments and removed prime discard volume from msg payload

- -33
- +1
/TDDefs.h
- History
- Source
- Diff
/TDDefs.h

12:43 pm

Raghu Kallala

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

11:36 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Balancing chamber switching control

11:32 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

11:29 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

remove the space before false.

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line.

11:01 am

Michael Garthwaite and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3676-1
finished reviewing

11:01 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

Align comments.

11:00 am

Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-1195-2
finished reviewing

11:00 am

Sean Nash

10:57 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

Can we just remove this?

10:57 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

Can we just remove this?

10:56 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

F suffix.

10:52 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

Is bicarbonate also a conversion factor?

10:49 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-473-3
commented on review

Can we just remove the old enum now?

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

10:43 am