leahi-common

Clone Tools

Stats

Commits this week: 27
Total Committers: 20
Last Commit: 18 Jun
Commits this week: 27

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Jun
11:29 am

Vendor - TEL - Praneeth Bunne

LDT-4013-1: Addressed CR comments

Options
    • -0
    • +1
    /TDDefs.h
10:49 am

Vendor - TEL - Varshini Nagabooshanam

Merge conflix fix

Options
    • -8
    • +3
    /MsgDefs.h
10:45 am

Sean Nash

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connectio...

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

9:52 am

Vendor - TEL - Arpita Srivastava

pressure is a param

pressure is a param

9:51 am

Vendor - TEL - Arpita Srivastava

command is a param

command is a param

9:49 am

Vendor - TEL - Arpita Srivastava

Inputs and Outputs should be none

Inputs and Outputs should be none

9:47 am

Vendor - TEL - Arpita Srivastava

Inputs and Outputs should be none

Inputs and Outputs should be none

9:45 am

Vendor - TEL - Arpita Srivastava

output should be none

output should be none

9:37 am

Vendor - TEL - Arpita Srivastava

break this into two lines

break this into two lines

9:37 am

Vendor - TEL - Arpita Srivastava

Similarly, we can move this to line 282 and delete handleBPDriverClearCmdAfterAckState()

Similarly, we can move this to line 282 and delete handleBPDriverClearCmdAfterAckState()

9:35 am

Vendor - TEL - Arpita Srivastava

We can move this line to 247 and delete handleBPDriverSendCmdState()

We can move this line to 247 and delete handleBPDriverSendCmdState()

9:32 am

Sean Nash

Should we be looking at tubing set type instead of modality here?

Should we be looking at tubing set type instead of modality here?

9:31 am

Vendor - TEL - Arpita Srivastava

Add an else block and keep the state to idle. In the beginning of the function assign the state to BP_DRIVER_CLEAR_CMD_STATE and remove line 194, 202 and 208.

Add an else block and keep the state to idle.
In the beginning of the function assign the state to BP_DRIVER_CLEAR_CMD_STATE and remove line 194, 202 and 208.

9:28 am

Sean Nash

Can we not determine this now? Why TODO?

Can we not determine this now? Why TODO?

9:27 am

Sean Nash

Shouldn't we be checking tubing set type instead of modality here?

Shouldn't we be checking tubing set type instead of modality here?

9:24 am

Vendor - TEL - Arpita Srivastava

add requestAdultBPMeasurement to outputs

add requestAdultBPMeasurement to outputs

9:23 am

Sean Nash

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

9:22 am

Sean Nash

Initialize to UNKNOWN type. Remove TODO.

Initialize to UNKNOWN type. Remove TODO.

9:21 am

Sean Nash

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

9:18 am

Sean Nash

Use /// when above, use ///< when to the right. Also remove extra space before Tube

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

9:17 am

Sean Nash

Change // to ///<

Change // to ///<

9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

7:12 am

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

6:49 am

Vendor - TEL - Sameer Poyil

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

6:45 am

Vendor - TEL - Sameer Poyil

will address it in new file created for mixing

will address it in new file created for mixing

4:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Thursday 11 Jun
10:29 pm

Vendor - TEL - Praneeth Bunne