leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 13
Total Committers: 16
Last Commit: 16:07
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Apr
3:14 pm

Vinayakam Mani

LDT-3352 updating code review comments

Options
    • -1
    • +0
    /MsgDefs.h
2:35 pm

Sean Nash

Remove this blank line.

Remove this blank line.

2:35 pm

Sean Nash

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

2:34 pm

Sean Nash

Remove blank line.

Remove blank line.

2:33 pm

Sean Nash

Remove blank line.

Remove blank line.

2:31 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

2:31 pm

Sean Nash

Remove blank line.

Remove blank line.

2:31 pm

Sean Nash

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?

2:27 pm

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

2:26 pm

Sean Nash

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

2:26 pm

Sean Nash

Why do we need this?

Why do we need this?

2:24 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:19 pm

Sean Nash

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

2:16 pm

Sean Nash

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

2:14 pm

Sean Nash

Let's remove this commented line.

Let's remove this commented line.

2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

1:34 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:48 am

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicarb closed loop control, fixing documentation error

Options
    • -1
    • +1
    /MsgDefs.h
11:39 am

Vendor - TEL - Sameer Poyil

LDT-2004 drybicart closed loop control

Options
    • -12
    • +12
    /MsgDefs.h
11:18 am

Vendor - TEL - Sameer Poyil

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

11:10 am

Vendor - TEL - Sameer Poyil

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.

11:08 am

Vendor - TEL - Sameer Poyil

Its a problem . Vinay has to decide it

Its a problem . Vinay has to decide it

11:07 am

Vendor - TEL - Arpita Srivastava

LDT:3505-Reverted back heaprin changes of MsgDefs.h and TDDefs.h

Options
    • -2
    • +0
    /MsgDefs.h
  2. … 1 more file in changeset.
9:32 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
  2. … 2 more files in changeset.
9:24 am

Michael Garthwaite