Activity leahi-common/MsgDefs.h

12:02 pm

suresh

More
983c3c3
changed 3 files
LDT-4063-power-control-and-post---fw-imp LEAHI-TD-FIRMWARE-LDT-4063-1

LDT-4063: Added alarms and msg ids

- -3
- +4
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
… 2 more files in changeset.

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4160-1
commented on review

mesage payload is not an input. We correctly mentioned it in the param. Input should be none as we are not reading any global or static variable declared at file level.

mesage payload is not an input. We correctly mentioned it in the param.
Input should be none as we are not reading any global or static variable declared at file level.

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4160-1
commented on review

Output should be none as we are not updating any global or static variable declared at file level.

10:49 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4160-1
commented on review

Please convert the function to have only single point of return. You can assign result = FALSE here. Also check for whitespace characters. Use 4 spaces instead of tab.

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

10:47 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4160-1
commented on review

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

10:33 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4160-1
commented on review

Why are we adding this header here?

9:02 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-4003-1
started review

LEAHI-TD-FIRMWARE-LDT-4003_HDF - FW Implementation - 4/4:

4:02 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4612-1
started review

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:

12:04 pm

Vendor - TEL - Vijay Pamula

10:15 am

Dara Navaei

More
481e12e
changed 2 files
LDT-3215-measured-venous-pressure-decreases, LDT-4003-hdf-fw-implementation-4-4 and 7 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
… 1 more file in changeset.

5:55 pm

Vendor - TEL - Arpita Srivastava

More
29063fb
changed 2 files
LDT-3735-non-volatile-memory LEAHI-DD-FIRMWARE-LDT-3735-1

LDT-3735: Added Alarm ids and msg ids for calibration records

- -12
- +30
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
… 1 more file in changeset.

5:13 pm

Vendor - TEL - Varshini Nagabooshanam

More
c596edc
changed 1 file
LDT-2240-disposable-tube-set-self-test LEAHI-TD-FIRMWARE-LDT-2240-1

Merge Fixes

- -9
- +12
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:32 pm

Vendor - TEL - Sameer Poyil

More
0e8b7ad
changed 1 file
develop

Merge branch LDT-4409-dialysate-composition-beta-2.1-WCID-implementation into develop

- -2
- +3
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:21 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

More
edf4f5e
changed 1 file
bugfix/LDT-4160-request-get-function-for-full-d LEAHI-TD-FIRMWARE-LDT-4160-1

Fixed indents for the message ids in MSDefs

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

2:09 pm

Vendor - TEL - Sameer Poyil

More
8cfb792
changed 2 files
LDT-3215-measured-venous-pressure-decreases, LDT-4003-hdf-fw-implementation-4-4 and 9 more LEAHI-DD-FIRMWARE-LDT-4409-2

LDT-4409 drybicart firmware implementation plus mixing control implementation

- -0
- +1
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h
… 1 more file in changeset.

1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-4409-2
resumed reviewing

1:16 pm

Vendor - TEL - Jashwant Gantyada

More
LEAHI-DD-FIRMWARE-LDT-4409-2
joined review

12:49 pm

Dara Navaei

More
5d03d89
changed 1 file
LDT-3215-measured-venous-pressure-decreases, LDT-4003-hdf-fw-implementation-4-4 and 9 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/MsgDefs.h
- History
- Source
- Diff
/MsgDefs.h

12:41 pm

Michael Garthwaite

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

10:59 am