Activity leahi-dialin/leahi_dialin/fp/modules/levels.py

12:05 pm

Vendor - TEL - Sameer Poyil

More
b0929a0
changed 1 file
LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more LEAHI-DIALIN-LDT-3984-1

LDT-3984 addressed review comments

- -1
- +1
./levels.py
- History
- Source
- Diff
./levels.py

9:30 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3984-1
commented on review

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3984-1
commented on review

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3984-1
commented on review

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3984-1
commented on review

LEVEL_OFFSET?

8:46 pm

Sean Nash and Raghu Kallala

More
LEAHI-DIALIN-LDT-3984-1
resumed reviewing

8:44 pm

Vendor - TEL - Sameer Poyil

More
03cf6f1
changed 4 files
LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more LEAHI-DIALIN-LDT-3984-1

LDT-3984 fix for conductivie level sensors d46, d63,d98

- -1
- +3
./levels.py
- History
- Source
- Diff
./levels.py
… 3 more files in changeset.

10:45 pm

Vendor - TEL - Sameer Poyil

More
106e58f
changed 3 files
LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more LEAHI-DIALIN-LDT-3984-1

LDT-3984 conductive level sensor dialin implementation

- -3
- +5
./levels.py
- History
- Source
- Diff
./levels.py
… 2 more files in changeset.

8:02 am

Dara Navaei

More
LEAHI-DIALIN-LDT-3984-1
started review

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber

9:39 am

Sean Nash

More
LEAHI-DIALIN-LDT-2655-1
finished reviewing

10:06 am

Michael Garthwaite

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( ...

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

10:46 am