ModePostGenDialysate.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
I believe we will want BC control during ISO UF state.

I believe we will want BC control during ISO UF state.

Remove blank line and comment saying we're not doing anything (because now we're doing something).

Remove blank line and comment saying we're not doing anything (because now we're doing something).

isBalChamberSwitchingOffRequested is an output.

isBalChamberSwitchingOffRequested is an output.

Should we set the other switch to FALSE, just in case?

Should we set the other switch to FALSE, just in case?

LDT-1195: Added a variable to keep track of balancing chamber switching activity.

  1. … 8 more files in changeset.
LDT-1195: Updated balancing chamber switching request flags names and definitions.

  1. … 8 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LDT-1195: Added Balancing Chamber Idle state

  1. … 6 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done

Done

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

stop should be capitalized.

stop should be capitalized.

Remove extra blank line.

Remove extra blank line.

I think these two conditions above the switch statement should end the state processing. So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE...

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

Done.

Done.

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

LDT-319 code review comments incorporation

  1. … 5 more files in changeset.
Signal Pre Gen mode and let it request standby mode.

Signal Pre Gen mode and let it request standby mode.

Should signal Gen Dialysate mode and let it request transition to standby.

Should signal Gen Dialysate mode and let it request transition to standby.