leahi-common

Clone Tools

Stats

Commits this week: 17
Total Committers: 16
Last Commit: 10 Apr
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Feb
9:00 am

Vendor - TEL - Sameer Poyil

LDT-2004-3 implementing review comments

Options
    • -1
    • +1
    /DDDefs.h
Thursday 05 Feb
7:27 pm

Vendor - TEL - Sameer Poyil

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

7:24 pm

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

3:45 pm

Raghu Kallala

LDT-3344 reverted DD valve changes

Options
    • -2
    • +2
    /DDDefs.h
3:41 pm

Dara Navaei

Merged staging

Options
    • -1
    • +1
    /DDDefs.h
    • -2
    • +2
    /MsgDefs.h
3:39 pm

Raghu Kallala

LDT-3344 merge latest from staging

Options
    • -3
    • +3
    /DDDefs.h
3:20 pm

Vendor - TEL - Jashwant Gantyada

LDT-3344 changes made to registers

Options
    • -4
    • +4
    /DDDefs.h
2:17 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
1:01 pm

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

12:53 pm

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

11:10 am

Nicholas Ramirez , Behrouz NematiPour and Tiffany Mejia

11:09 am

Dara Navaei

Merged LDT-3323

Options
11:04 am

Dara Navaei

LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
11:03 am

Vinayakam Mani

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

10:46 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
10:44 am

Stephen Quong

LDT-3328: Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I - 05: DEV - Feature Implementation

- Updated TDDefs.h to add Blood Prime command enums.

Options
    • -0
    • +12
    /TDDefs.h
10:24 am

Vinayakam Mani

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

10:19 am

Vinayakam Mani

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

10:17 am

Vinayakam Mani

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

9:59 am

Vinayakam Mani

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

Wednesday 04 Feb
4:59 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /AlarmDefs.h
    • -1
    • +1
    /DDDefs.h
    • -2
    • +2
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:55 pm

Vendor - TEL - Varshini Nagabooshanam

Merged LDT-1415-pressures-monitoring-td

Options
4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
4:36 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-1415-pressures-monitoring-td

Options
    • -2
    • +3
    /MsgDefs.h
2:34 pm

Vendor - TEL - Varshini Nagabooshanam

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

2:10 pm

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed