leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2004-3 implementing review comments

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

This was a concern reported by Sean and proposed for restructuring into a single state machine.

LDT-3344 reverted DD valve changes

Merged staging

LDT-3344 merge latest from staging

LDT-3344 changes made to registers

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

Merged LDT-3323

LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LDT-3328: Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I - 05: DEV - Feature Implementation

- Updated TDDefs.h to add Blood Prime command enums.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged LDT-1415-pressures-monitoring-td

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Merge branch 'staging' into LDT-1415-pressures-monitoring-td

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

Yes, updated

Yes, updated

Removed

Removed