leahi-common

Clone Tools

Stats

Commits this week: 16
Total Committers: 19
Last Commit: 29 May
Commits this week: 16

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Apr
10:09 am

Vendor - TEL - Arpita Srivastava

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-common into LDT-1195-dd-is-balancing-chamber-switching

Options
10:06 am

Vendor - TEL - Sameer Poyil

10:06 am

Vendor - TEL - Sameer Poyil

do we need bracket here ? all text should start with capital

do we need bracket here ? all text should start with capital

10:00 am

Vendor - TEL - Sameer Poyil

Why a * here ?

Why a * here ?

9:43 am

Vendor - TEL - Sameer Poyil

is it write states or read state ?

is it write states or read state ?

9:43 am

Vendor - TEL - Sameer Poyil

is documentation correct ?

is documentation correct ?

8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Thursday 09 Apr
2:35 pm

Dara Navaei

LDT-3259 merged staging and reserved new messages for TD and DD update signals

Options
    • -30
    • +50
    /AlarmDefs.h
    • -13
    • +62
    /DDDefs.h
    • -23
    • +62
    /MsgDefs.h
Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

10:39 am

Raghu Kallala

From what I see in UI, it is just a range value not an enum/index

From what I see in UI, it is just a range value not an enum/index

10:14 am

Michael Garthwaite

LDT-2008: reverted Alarm IDs for compilation

Options
    • -4
    • +4
    /AlarmDefs.h
9:43 am

Michael Garthwaite

LDT-2008: updated alarm IDs

Options
    • -4
    • +4
    /AlarmDefs.h
8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

2:50 pm

Michael Garthwaite

LDT-2008: added alarms and msg ids for version request. alarms are for cond sensor faults.

Options
    • -0
    • +8
    /AlarmDefs.h
    • -0
    • +8
    /MsgDefs.h
8:53 am

Michael Garthwaite

Merge branch 'staging' into LDT-2008-v2-conductivity-sensors-CLEAN

Options
    • -2
    • +2
    /MsgDefs.h
Monday 06 Apr
7:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
4:43 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: Added Calibration Events for NVM

Options
    • -0
    • +9
    /DDDefs.h
2:13 pm

Raghu Kallala

LDT-473 added new UF volume and weights inconsistency rejection

Options
    • -0
    • +1
    /MsgDefs.h
2:12 pm

Sean Nash