SystemCommDD.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove this flag.

Remove this flag.

Remove this code.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?

What is the point of this message?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3272_Software Update - DD
LEAHI-DD-FIRMWARE-LDT-3272_Software Update - DD
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done

Done

Done