leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch staging into LDT-3978-switch-chamber-f-conductive-lev

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-473 merge latest into develop

LDT-473 merge latest into staging

LDT-473 merge latest from staging

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

Is this still needed?

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

No longer needed?

Revert "LDT-3978 conductive level sensor implementation for chamber F fill"

This reverts commit c307972e2a605d62e355847007e0db0c9876cf52.

LDT-473 removed confirmation as a param

???

???

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

LDT-1886: Removed invalid payload rej reason

Remove space after 'Supply'.

Remove space after 'Supply'.

Align the value declaration indentation.

Align the value declaration indentation.

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

Merge branch LDT-3978-switch-chamber-f-conductive-lev into develop

LDT-3978 fix override request for D6 and P25

Merge branch 'LDT-3978-switch-chamber-f-conductive-lev' of bitbucket.org:diality-cloud/leahi-common into LDT-3978-switch-chamber-f-conductive-lev

LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4: