leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 13
Total Committers: 16
Last Commit: 23 Apr
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 30 Mar
2:45 pm

Michael Garthwaite

LDT-2008: updates to msg id's

Options
    • -1
    • +1
    /MsgDefs.h
1:54 pm

Michael Garthwaite

1:46 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
1:43 pm

Raghu Kallala

LDT-3603 redo of FP set operation sub mode on a new branch

Options
    • -0
    • +1
    /MsgDefs.h
10:15 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:14 am

Sean Nash

This "s" looks out of place.

This "s" looks out of place.

10:14 am

Sean Nash

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

Friday 27 Mar
7:56 am

Vendor - TEL - Sameer Poyil

No, its deleted

No, its deleted

7:54 am

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

Thursday 26 Mar
11:37 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd into develop

Options
    • -0
    • +22
    /MsgDefs.h
4:21 pm

Michael Garthwaite

Merge branch 'LDT-3218-update-iofp-permeate-target-flow-CLEAN' into develop

Options
    • -0
    • +1
    /MsgDefs.h
4:20 pm

Michael Garthwaite

LDT-3218: updated msg id's in relation to develop

Options
    • -1
    • +1
    /MsgDefs.h
12:03 pm

Michael Garthwaite

LDT-3218: created MSG_ID for setting valve recovery config.

Options
    • -0
    • +1
    /MsgDefs.h
2:33 am

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicarb and acid closee loop control

Options
    • -10
    • +12
    /MsgDefs.h
Wednesday 25 Mar
1:36 pm

Vendor - TEL - Sameer Poyil

LDT-2004 bicarb closed loop control

Options
    • -0
    • +22
    /MsgDefs.h
11:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Tuesday 24 Mar
9:31 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD
LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD
9:23 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -0
    • +3
    /MsgDefs.h
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

2:30 pm

Sean Nash and Michael Garthwaite

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?