leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 15
Total Committers: 17
Last Commit: 06 May
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
5:11 pm

Michael Garthwaite

LDT-4000: substitution pump override ids. floater level override request.

Options
    • -0
    • +4
    /MsgDefs.h
3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

2:23 pm

Vendor - TEL - Sameer Poyil

1:42 pm

Sean Nash

1:36 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -2
    • +2
    /MsgDefs.h
  2. … 1 more file in changeset.
10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Wednesday 29 Apr
1:47 pm

Vendor - TEL - Sameer Poyil

Merge branch staging into LDT-3978-switch-chamber-f-conductive-lev

Options
    • -5
    • +9
    /MsgDefs.h
11:02 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /MsgDefs.h
  2. … 1 more file in changeset.
11:01 am

Raghu Kallala

LDT-473 merge latest into develop

Options
    • -4
    • +8
    /MsgDefs.h
  2. … 1 more file in changeset.
10:57 am

Raghu Kallala

10:55 am

Raghu Kallala

LDT-473 merge latest from staging

Options
    • -176
    • +188
    /MsgDefs.h
10:44 am

Vinayakam Mani

9:57 am

Sean Nash

Keep 2 blank lines above the banner below.

Keep 2 blank lines above the banner below.

9:56 am

Sean Nash

Is this still needed?

Is this still needed?

9:56 am

Sean Nash

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

9:49 am

Sean Nash

Keep 2 blank lines above the test support functions banner.

Keep 2 blank lines above the test support functions banner.

9:47 am

Sean Nash

Not sure why you are making changes to this function. This function handles message from UI to pause or resume ultrafiltration. This is not a treatment parameter edit message, so I don't think it's...

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

9:43 am

Sean Nash

No longer needed?

No longer needed?

9:42 am

Sean Nash

9:42 am

Sean Nash

9:23 am

Michael Garthwaite

Revert "LDT-3978 conductive level sensor implementation for chamber F fill"

This reverts commit c307972e2a605d62e355847007e0db0c9876cf52.

Options
    • -2
    • +1
    /MsgDefs.h
Tuesday 28 Apr
6:13 pm

Sean Nash

2:31 pm

Sean Nash

???

???

2:30 pm

Sean Nash

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..