leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 14
Total Committers: 18
Last Commit: 12 Jun
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jun
9:22 am

Michael Garthwaite

Merge branch 'LDT-4001-hdf-fw-implementation-2-4' into develop

Options
    • -3
    • +5
    /MsgDefs.h
  2. … 1 more file in changeset.
9:07 am

Michael Garthwaite

Merge branch 'staging' into LDT-4001-hdf-fw-implementation-2-4

Options
    • -8
    • +9
    /MsgDefs.h
  2. … 1 more file in changeset.
Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

2:54 pm

Vendor - TEL - Vijay Pamula

LDT-4329: Updated Vitals Adjustment Implementation

Options
    • -0
    • +2
    /MsgDefs.h
11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

11:37 am

Vendor - TEL - Praneeth Bunne

Merge branch LDT-4013-fluid-bolus & resolve merge conflicts

Options
    • -6
    • +7
    /MsgDefs.h
  2. … 1 more file in changeset.
10:29 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
  2. … 2 more files in changeset.
10:08 am

Sean Nash

9:32 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
LEAHI-TD-FIRMWARE-LDT-4063_Power Control and POST - FW Implementation - 1/6:
Thursday 04 Jun
10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
10:22 am

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -8
    • +12
    /MsgDefs.h
  2. … 1 more file in changeset.
10:21 am

Michael Garthwaite

LDT-4485: updated MSG ids to contain resistance data for conductivity sensors

Options
    • -0
    • +1
    /MsgDefs.h
9:52 am

Vendor - TEL - Jashwant Gantyada

9:33 am

Vendor - TEL - Praneeth Bunne

LDT-4013: Merge latest staging into LDT-4013 and resolved merge conflicts

Options
    • -9
    • +28
    /MsgDefs.h
  2. … 2 more files in changeset.
9:00 am

Sean Nash

Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

Wednesday 03 Jun
12:29 pm

Vinayakam Mani

9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.