leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 12
Total Committers: 19
Last Commit: 03 Jul
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Jun
2:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
2:16 pm

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -4
    • +4
    /MsgDefs.h
  2. … 1 more file in changeset.
2:16 pm

Michael Garthwaite

Merge branch 'staging' into LDT-4485-dd-conductivity-sensors-d17

Options
    • -8
    • +13
    /MsgDefs.h
2:01 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

1:11 pm

Vendor - TEL - Vijay Pamula

LDT-4329: Merge latest Staging

Options
    • -2
    • +6
    /MsgDefs.h
10:49 am

Vendor - TEL - Varshini Nagabooshanam

Merge conflix fix

Options
    • -8
    • +3
    /MsgDefs.h
9:32 am

Sean Nash

Should we be looking at tubing set type instead of modality here?

Should we be looking at tubing set type instead of modality here?

9:28 am

Sean Nash

Can we not determine this now? Why TODO?

Can we not determine this now? Why TODO?

9:27 am

Sean Nash

Shouldn't we be checking tubing set type instead of modality here?

Shouldn't we be checking tubing set type instead of modality here?

9:23 am

Sean Nash

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

9:22 am

Sean Nash

Initialize to UNKNOWN type. Remove TODO.

Initialize to UNKNOWN type. Remove TODO.

9:21 am

Sean Nash

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

9:18 am

Sean Nash

Use /// when above, use ///< when to the right. Also remove extra space before Tube

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

9:17 am

Sean Nash

Change // to ///<

Change // to ///<

6:49 am

Vendor - TEL - Sameer Poyil

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

6:45 am

Vendor - TEL - Sameer Poyil

will address it in new file created for mixing

will address it in new file created for mixing

4:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Thursday 11 Jun
10:29 pm

Vendor - TEL - Praneeth Bunne

4:18 pm

Vendor - TEL - Varshini Nagabooshanam

Merge Fixes

Options
    • -14
    • +29
    /MsgDefs.h
  2. … 2 more files in changeset.
2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
  2. … 1 more file in changeset.
2:24 pm

Michael Garthwaite

1:27 pm

Vinayakam Mani and Sean Nash

11:20 am

Vendor - TEL - Arpita Srivastava

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

11:20 am

Vendor - TEL - Arpita Srivastava

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

11:13 am

Vendor - TEL - Arpita Srivastava

Alarm id should be 196? Description looks same as 194.

Alarm id should be 196?
Description looks same as 194.

10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:07 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -1
    • +1
    /MsgDefs.h
10:00 am

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.