leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'LDT-3218-update-iofp-permeate-target-flow-CLEAN' into staging

0.0F is made by Sean.

0.0F is made by Sean.

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

LDT-3735: Deleted DD events for NVM heater infor, scheduled runs and sw config

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

LDT-2240-disposable-tube-set-self-test

COMM_BUFFER_OUT_CAN_FP_BROADCAST sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

LDT-2240-disposable-tube-set-self-test

DO we need bicarb conversion factor as well?

DO we need bicarb conversion factor as well?

LDT-3352 resolving merge conflicts

Do we know which channel this event will be sent on?

Do we know which channel this event will be sent on?

nope. removed.

nope. removed.

fixed

fixed

fixed

fixed

fixed

fixed

fixed

fixed

preweight can be non-zero

preweight can be non-zero

LDT-3218: fixed msg ids for dd conductivity version request

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow-CLEAN

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

LDT-3352 merge into staging

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

Remove this comment.

Remove this comment.